Skip to content

cmd: test publish using temp enr key#3807

Merged
obol-bulldozer[bot] merged 2 commits into
mainfrom
pinebit/test-temp-p2p-key
Jun 26, 2025
Merged

cmd: test publish using temp enr key#3807
obol-bulldozer[bot] merged 2 commits into
mainfrom
pinebit/test-temp-p2p-key

Conversation

@pinebit

@pinebit pinebit commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator

For alpha test command, when --publish is specified and there is no private key present at .charon/charon-enr-private-key, the implementation will auto generate temporary private key that will not be matching any of real nodes on the backend, but still allows to proceed and publish.

category: feature
ticket: none

@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.13%. Comparing base (f48d03a) to head (522b20f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cmd/test.go 50.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3807      +/-   ##
==========================================
- Coverage   54.15%   54.13%   -0.03%     
==========================================
  Files         227      227              
  Lines       35735    35817      +82     
==========================================
+ Hits        19354    19389      +35     
- Misses      14254    14291      +37     
- Partials     2127     2137      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cmd/test.go
@pinebit pinebit added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jun 26, 2025
@sonarqubecloud

Copy link
Copy Markdown

@obol-bulldozer obol-bulldozer Bot merged commit fb54af4 into main Jun 26, 2025
11 checks passed
@obol-bulldozer obol-bulldozer Bot deleted the pinebit/test-temp-p2p-key branch June 26, 2025 11:40
KaloyanTanev pushed a commit that referenced this pull request Jun 26, 2025
For `alpha test` command, when `--publish` is specified and there is no private key present at `.charon/charon-enr-private-key`, the implementation will auto generate temporary private key that will not be matching any of real nodes on the backend, but still allows to proceed and publish.

category: feature
ticket: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants