request through a proxyPass problem #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgedhallpass
requested changes
Mar 22, 2024
csrfguard/src/main/java/org/owasp/csrfguard/servlet/JavaScriptServlet.java
Outdated
Show resolved
Hide resolved
csrfguard/src/main/java/org/owasp/csrfguard/servlet/JavaScriptServlet.java
Outdated
Show resolved
Hide resolved
change request 1
Contributor
Author
|
I applied your requests to the code. Let me know if now it's ok |
forgedhallpass
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the traffic flows across a proxyPass, this condition of csrfguard.js is not more satisfied.
The user will receive this error:
The problem lies in request.getRequestURL() used by JavaScriptServlet to get the domain origin. When there is a proxyPass between browser and web-Server, "request.getRequestURL()" returns the computer address of the local web-server as seen by the proxyPass server and not the external proxypass url requested by the client browser.
In this pull-request I modified the JavaScriptServlet so that the class prefers the "X-Forwarded-Host" header if it was populated by proxyPass. This header identifies the original host requested by the client in the Host HTTP request header.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host