MSTG-NETWORK-1 Added clearText Traffic Info#2037
Merged
cpholguera merged 17 commits intomasterfrom Jan 25, 2022
Merged
Conversation
cpholguera
requested changes
Jan 23, 2022
Collaborator
There was a problem hiding this comment.
Thanks @TheDauntless, one first comment before reviewing the content itself. Could you please put all code-like elements in backticks? e.g. android:... or <application>.
Why XML elements have a \ preceding them?
See https://github.com/OWASP/owasp-mstg/blob/master/style_guide.md#in-text-keywords
cpholguera
requested changes
Jan 24, 2022
Collaborator
cpholguera
left a comment
There was a problem hiding this comment.
Thanks @TheDauntless, here are a couple of comments and suggestions. Please take a look :)
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
Collaborator
Author
|
All comments have been processed. I would prefer to link to a dedicated section on cross-platform frameworks, but since we don't have that one, I'm fine with giving an example for now. |
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: cpholguera <perezholguera@gmail.com>
cpholguera
reviewed
Jan 24, 2022
cpholguera
reviewed
Jan 24, 2022
Co-authored-by: cpholguera <perezholguera@gmail.com>
cpholguera
approved these changes
Jan 25, 2022
Collaborator
cpholguera
left a comment
There was a problem hiding this comment.
Thanks @TheDauntless 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:
If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2008