fix: resolve N+1 query in allocations getByUserIdAndThreshold#400
Open
alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
Open
fix: resolve N+1 query in allocations getByUserIdAndThreshold#400alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
Conversation
Replace per-allocation getUserById calls with a single batched getUsersByIds query using $in, deduplicating userIds to minimize the MongoDB round-trips from N to 1. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allocations-dao.jsgetByUserIdAndThreshold: replaced the per-allocationgetUserByIdloop (one MongoDB round-trip per allocation) with a single batchedgetUsersByIdscall using$in, reducing DB round-trips from N to 1.getUsersByIdstouser-dao.js— accepts an array of user IDs, deduplicates them, and fetches all matching users in one query.Test plan
getByUserIdAndThresholdreturns correct user details (userName,firstName,lastName) on each allocationuserscollection query is issued regardless of allocation countuserId(no duplicate fetches)Made with Cursor