vBot support "Mage" vocation#76
Merged
divinity76 merged 1 commit intoOTAcademy:masterfrom Jan 20, 2026
Merged
Conversation
several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED. Without this fix, on those servers, vBot would constantly error out with Error: (...) concatenat voc: a nil value I tried submitting this upstream, but it seems vBot upstream is unmaintained: Vithrax/vBot#17
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the "Mage" vocation in vBot, which is used by some OT servers that merge the MS (Sorcerer) and ED (Druid) vocations. The change also optimizes the code by caching the lowercased text to avoid repeated calls to text:lower().
Changes:
- Added detection for "mage" vocation and mapped it to "MS"
- Introduced
lowerTextvariable to cachetext:lower()for better performance - Updated all vocation checks to use the cached
lowerTextvariable
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several OT servers merge MS/ED vocation into a Mage vocation having the best features of both MS and ED.
Without this fix, on those servers, vBot would constantly error out with
Error: (...) concatenat voc: a nil valueI tried submitting this upstream, but it seems vBot upstream is unmaintained: Vithrax/vBot#17