Fix transect subset selection bug and increment version for new release #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiliom
added
the
bug_in_python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #95, a bug in the new transect subset selection scheme where "missing" strata were not being handled in the calculation of transect
NASC_adult. Adds a new test for transect selection and includes some small, cosmetic code tweaks.The implementation in this PR reverts to the simple, interim scheme being used before this release, described in #33. An implementation that reflects the Matlab implementation more faithfully will be addressed in the next release.
Also increments the version to 0.3.1 in preparation for the new release.