-
Notifications
You must be signed in to change notification settings - Fork 5
Change input data column names #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome, thanks! I'll review this PR tomorrow. |
|
Restating for full clarity: In #34 we have come to a collective conclusion that referencing Hake is fine for the current state of EchoPro. For this reason, we will continue to use the name |
emiliom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made some small suggestions, just to improve consistency or add clarity. I don't think I ran into any actual problems.
|
@emiliom I am done addressing and responding to your comments. This PR is ready for another review. |
|
Everything looks good. The only open question is the one about |
|
@emiliom I have went ahead and changed the input name |
emiliom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good. Merge away.
This PR addresses issue #19 by changing all data column names to those specified in echopro_final_column_names. Additionally, the following items were completed:
Note: This PR is currently a draft because of the comment in issue 19, which suggests changing
fraction_haketofraction_species.