Skip to content

Conversation

@brandynlucca
Copy link
Collaborator

The off-effort transect filter (ingest_nasc.filter_transect_intervals) was not producing the same sized dataframes as expected when comparing to the outputs from EchoPro's remove_unwated_zeros.m. This has now been rectified and tested for all years between 2003 and 2012 (as noted in #404).

@brandynlucca brandynlucca self-assigned this Oct 9, 2025
@brandynlucca brandynlucca linked an issue Oct 9, 2025 that may be closed by this pull request
6 tasks
@brandynlucca brandynlucca added the bug_in_python Something in the Python implementation does not match what's in Matlab label Oct 9, 2025
@brandynlucca brandynlucca marked this pull request as ready for review October 9, 2025 20:16
@brandynlucca brandynlucca requested a review from leewujung October 9, 2025 20:16
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandynlucca : I only have a very minor comment above, but I do have a request: Could you can add a schematic that shows the procedure in # Process each unique transect that has filter intervals? Seems like that would be more intuitive (since you already sorted out what Chu's operations were doing). Thanks!

@brandynlucca
Copy link
Collaborator Author

@leewujung:

I only have a very minor comment above, but I do have a request: Could you can add a schematic that shows the procedure in # Process each unique transect that has filter intervals? Seems like that would be more intuitive (since you already sorted out what Chu's operations were doing). Thanks!

Sure! Do you mean a schematic in the documentation (for the implementation?)? Or in the docstring?

@leewujung
Copy link
Member

In the documentation.

@brandynlucca brandynlucca merged commit 0c55ef0 into OSOceanAcoustics:main Nov 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug_in_python Something in the Python implementation does not match what's in Matlab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected outputs from the off-effort transect filter

2 participants