-
Notifications
You must be signed in to change notification settings - Fork 5
Apply fixes to off-effort transect filtering #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply fixes to off-effort transect filtering #408
Conversation
…e in `pydantic 3.12.0`
leewujung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandynlucca : I only have a very minor comment above, but I do have a request: Could you can add a schematic that shows the procedure in # Process each unique transect that has filter intervals? Seems like that would be more intuitive (since you already sorted out what Chu's operations were doing). Thanks!
Sure! Do you mean a schematic in the documentation (for the implementation?)? Or in the docstring? |
|
In the documentation. |
The off-effort transect filter (
ingest_nasc.filter_transect_intervals) was not producing the same sized dataframes as expected when comparing to the outputs fromEchoPro'sremove_unwated_zeros.m. This has now been rectified and tested for all years between 2003 and 2012 (as noted in #404).