Skip to content

Conversation

@brandynlucca
Copy link
Collaborator

This PR includes:

  • New function [distribute_transect_estimates] that performs a similar operation as distribute_kriged_estimates.
  • New class [FEATReports] that incorporates a variety of helper functions and methods to produce each report-type
  • Tests and fixtures for all helper functions, FEATReports initialization, and methods
  • Minor bug fixes

@brandynlucca brandynlucca self-assigned this Sep 14, 2025
@brandynlucca brandynlucca marked this pull request as ready for review September 14, 2025 07:22
Copy link
Member

@leewujung leewujung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandynlucca : Thanks for the PR. I have an inline comments about merging distribute_krige_estimates and distribute_transect_estimates, and some other comments below:

Could you add a notebook to show the exact steps to generate report using the class? I am not able to find it. I added an issue to track that. #397

test_FEATReports sits in test_class.py which only has 1 test underneath. Would be better to just change that to test_FEATReports.py. Are there other classes you plan to test in this script?

@brandynlucca brandynlucca force-pushed the refactor_FEAT_report_generation branch from dc7d2d1 to 487566e Compare September 22, 2025 23:34
@brandynlucca brandynlucca linked an issue Sep 22, 2025 that may be closed by this pull request
@brandynlucca brandynlucca linked an issue Sep 23, 2025 that may be closed by this pull request
@brandynlucca
Copy link
Collaborator Author

  • The distribution functions have been consolidated to a single distribute_population_estimates()
  • report_generation.py workflow example/demo file now exemplifies FEATReports usage

This can therefore be merged.

@brandynlucca brandynlucca merged commit 7940d99 into OSOceanAcoustics:main Sep 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notebook to illustrate use of FEATReports Add report generation to refactored code

2 participants