-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor FEAT report generation #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FEAT report generation #394
Conversation
leewujung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandynlucca : Thanks for the PR. I have an inline comments about merging distribute_krige_estimates and distribute_transect_estimates, and some other comments below:
Could you add a notebook to show the exact steps to generate report using the class? I am not able to find it. I added an issue to track that. #397
test_FEATReports sits in test_class.py which only has 1 test underneath. Would be better to just change that to test_FEATReports.py. Are there other classes you plan to test in this script?
dc7d2d1 to
487566e
Compare
for more information, see https://pre-commit.ci
…brandynlucca/echopop into refactor_FEAT_report_generation
for more information, see https://pre-commit.ci
This can therefore be merged. |
This PR includes:
distribute_transect_estimates] that performs a similar operation asdistribute_kriged_estimates.FEATReports] that incorporates a variety of helper functions and methods to produce each report-typeFEATReportsinitialization, and methods