-
Notifications
You must be signed in to change notification settings - Fork 5
Refactor basic plotting functions #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor basic plotting functions #381
Conversation
leewujung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brandynlucca : Thanks for the PR - the additions look good!
I couldn't find a .py file that demonstrate the use of the added plotting functions, but not sure if I miss anything since there are many files irrelevant to this PR on the nav bar.
Could you make a separate .py that loads results from feat_hake.py to generate these plots and save them as PNG in a demo folder? Be careful with the savefig arguments since sometimes without the right combination the saved fig would not have the right background or be cut off on the side, etc. Please also include demonstration of what should be included in each of the *_kwargs so that people know how to use them (aside from having those info in the docstrings). Would be great to have a couple lines about the include_filter and exclude_filter since it's a recurrent pattern in Echopop and having it everywhere would help people grasp their use.
39a5073 to
0ffab75
Compare
…eyword arguments
|
There is now a |
This PR includes the refactored plotting functions for the transect results, kriged mesh results, and age-length population heatmap. This also includes accompanying tests and fixtures.