Translation dictionary for data column names #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leewujung
reviewed
Sep 11, 2024
leewujung
reviewed
Sep 12, 2024
leewujung
approved these changes
Sep 12, 2024
Member
leewujung
left a comment
leewujung
left a comment
There was a problem hiding this comment.
I think this can be merged as is, but I feel that validate_data_columns and read_validated_data can be combined into a single function. I also feel like I've made this comment before?? or maybe I made the reverse of this comment and the functions were actually split out from one?? I don't remember...
leewujung
reviewed
Sep 13, 2024
leewujung
approved these changes
Sep 13, 2024
Member
leewujung
left a comment
leewujung
left a comment
There was a problem hiding this comment.
Awesome! This looks a lot cleaner now. Other than my minor edit suggestion, feel free to merge!
Co-authored-by: Wu-Jung Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dictionary to
.corecalledNAME_CONFIGthat will translate particular columns in the acoustic, biological, kriging, and stratification datasets. In cases where column names (e.g.Frequency) are present, they will be converted into the naming scheme used byEchopop(e.g.Frequency -> length_count). Otherwise, the names remain the same and continue with being validated as normal.