refactor: replace Swashbuckle with Microsoft.AspNetCore.OpenApi#648
refactor: replace Swashbuckle with Microsoft.AspNetCore.OpenApi#648berezovskyi merged 2 commits intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughMigrates OpenAPI tooling from Swashbuckle.AspNetCore to Microsoft.AspNetCore.OpenApi: updates package references, replaces Swagger/Swashbuckle service and pipeline calls with AddOpenApi()/MapOpenApi(), and adjusts launch settings to point at openapi/v1.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Properties/launchSettings.json (1)
6-24:⚠️ Potential issue | 🟡 MinorUpdate Docker launch URL to OpenAPI endpoint as well.
Line 24still targets/swagger, so the Docker profile will launch to a stale path after this migration.Proposed fix
- "launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}/swagger", + "launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}/openapi/v1.json",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Properties/launchSettings.json` around lines 6 - 24, Update the Docker launch profile so its launchUrl points to the OpenAPI endpoint like the other profiles: locate the "Container (Dockerfile)" profile in launchSettings.json and change its "launchUrl" value from "{Scheme}://{ServiceHost}:{ServicePort}/swagger" to the OpenAPI path used elsewhere (e.g. "{Scheme}://{ServiceHost}:{ServicePort}/openapi/v1.json") so Docker launches the correct OpenAPI endpoint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@OSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Properties/launchSettings.json`:
- Around line 6-24: Update the Docker launch profile so its launchUrl points to
the OpenAPI endpoint like the other profiles: locate the "Container
(Dockerfile)" profile in launchSettings.json and change its "launchUrl" value
from "{Scheme}://{ServiceHost}:{ServicePort}/swagger" to the OpenAPI path used
elsewhere (e.g. "{Scheme}://{ServiceHost}:{ServicePort}/openapi/v1.json") so
Docker launches the correct OpenAPI endpoint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7ae49c57-5827-4978-83b3-57b3f5d33459
📒 Files selected for processing (4)
OSLC4Net_SDK/Directory.Packages.propsOSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/OSLC4NetExamples.Server.NetCoreApi.csprojOSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Program.csOSLC4Net_SDK/Examples/OSLC4NetExamples.Server.NetCoreApi/Properties/launchSettings.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #648 +/- ##
==========================================
+ Coverage 50.86% 51.87% +1.01%
==========================================
Files 174 174
Lines 10202 10248 +46
Branches 1010 1020 +10
==========================================
+ Hits 5189 5316 +127
+ Misses 4756 4677 -79
+ Partials 257 255 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit