r.sim: rename niterations to duration to better reflect what the parameter is for#7175
Merged
petrasovaa merged 1 commit intoOSGeo:mainfrom Mar 12, 2026
Merged
Conversation
wenzeslaus
approved these changes
Mar 12, 2026
Member
wenzeslaus
left a comment
wenzeslaus
left a comment
There was a problem hiding this comment.
Description seems to be clear, not raising many questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In r.sim.water and r.sim.sediment the parameter niterations is not actually number of iterations, but duration in minutes- the number of iterations is computed from it internally. So this just renames the parameter in a backwards compatible way.