-
-
Notifications
You must be signed in to change notification settings - Fork 420
Tests: add pytest-based test for rasterExists helper function #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ayushjariyal
wants to merge
8
commits into
OSGeo:main
Choose a base branch
from
ayushjariyal:pytest_testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c77a720
add pytest-based test for rasterExists function
ayushjariyal abdfe2e
register pytest
ayushjariyal 9e269cf
imporove code quality
ayushjariyal 0d362a9
Update python/grass/pytest/conftest.py
ayushjariyal ad5289d
Update python/grass/pytest/tests/test_assertions.py
ayushjariyal deffaeb
Update python/grass/pytest/conftest.py
ayushjariyal 2037c57
Update python/grass/pytest/tests/test_assertions.py
ayushjariyal 63be943
fix errors
ayushjariyal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ set(PYDIRS | |
| pygrass/shell | ||
| pygrass/tests | ||
| pygrass/vector | ||
| pytest | ||
| script | ||
| semantic_label | ||
| temporal | ||
|
|
||
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import grass.script as gs | ||
|
|
||
|
|
||
| def rasterExists(map_name, env=None): | ||
| """Check if a raster map exists in the given mapset.""" | ||
| result = gs.find_file(map_name, element="cell", env=env) | ||
| return bool(result["name"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import os | ||
| import pytest | ||
| import grass.script as gs | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def session(tmp_path): | ||
| project = tmp_path / "test_proj" | ||
| gs.create_project(project) | ||
|
|
||
| with gs.setup.init(project, env=os.environ.copy()) as session: | ||
| yield session.env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import grass.script as gs | ||
| from grass.pytest.assertions import rasterExists | ||
|
|
||
|
|
||
| def test_rasterExists(session): | ||
| gs.run_command("r.mapcalc", expression="test_map = 1", env=session) | ||
|
|
||
| assert rasterExists("test_map", env=session) | ||
| assert not rasterExists("missing_map", env=session) | ||
ayushjariyal marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.