g.region: Add more detail into error messages#1140
Merged
wenzeslaus merged 4 commits intoOSGeo:masterfrom Dec 6, 2020
Merged
Conversation
Messages such as 'Illegal col value' might be sufficient for a simple g.region call, but g.region is called at many different places indirectly and G_adjust_Cell_head, too, so col does not make much sense anymore. * This uses general terms (number of columns) instead of g.region options (col value). G_adjust_Cell_head is a library function after all. * Uses message colon value syntax where possible. * Explains why the error was triggered or shows the offending value.
lucadelu
approved these changes
Dec 2, 2020
…code duplication)
Member
Author
|
Thanks @lucadelu. The |
…s in the GUI or with g.region vector when extent is set separatelly from resolution and default resolution in lat-lon can ne much larger than the requested extent. Adjusting the resolution value in this case would go far beyond chanaging messages and may go beyond what should happen.
…tent and resolution.
wenzeslaus
added a commit
to wenzeslaus/grass
that referenced
this pull request
Nov 24, 2021
When setting up region in LL, this adds the actual values to the error messages in case these are computed in the g.region call or function call itself. The value may also provide more explanation to what was actually violated. Similar to OSGeo#1140 (e0ce155) but for the lat-lon extent cases.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
When setting up region in LL, this adds the actual values to the error messages in case these are computed in the g.region call or function call itself. The value may also provide more explanation to what was actually violated. Similar to OSGeo#1140 (e0ce155) but for the lat-lon extent cases.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
When setting up region in LL, this adds the actual values to the error messages in case these are computed in the g.region call or function call itself. The value may also provide more explanation to what was actually violated. Similar to OSGeo#1140 (e0ce155) but for the lat-lon extent cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages such as 'Illegal col value' might be sufficient for a simple g.region call,
but g.region is called at many different places indirectly and G_adjust_Cell_head, too,
so col does not make much sense anymore.
G_adjust_Cell_head and G_adjust_Cell_head3 are library functions after all.