Skip to content

remove unsupport diagnostic#6908

Merged
akva2 merged 1 commit intoOPM:masterfrom
akva2:hip_remove_unsupported_diag_suppression
Mar 18, 2026
Merged

remove unsupport diagnostic#6908
akva2 merged 1 commit intoOPM:masterfrom
akva2:hip_remove_unsupported_diag_suppression

Conversation

@akva2
Copy link
Member

@akva2 akva2 commented Mar 6, 2026

at least with rocm 7.1, hipcc does not support this diagnostic. and thus it obviously isn't necessary (any longer)

/build/hipify/build-opm-simulators/tests/gpuistl_hip/test_primary_variables_gpu.hip:33:34: warning: unknown warning group '-Wenum-constexpr-conversion', ignored [-Wunknown-warning-option]
   33 | #pragma clang diagnostic ignored "-Wenum-constexpr-conversion"

at least with rocm 7.1, hipcc does not support this diagnostic.
and thus it obviously isn't necessary (any longer)
@akva2 akva2 added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Mar 6, 2026
@akva2
Copy link
Member Author

akva2 commented Mar 6, 2026

jenkins build this hipify please

@akva2 akva2 merged commit b5c39c8 into OPM:master Mar 18, 2026
3 checks passed
@akva2 akva2 deleted the hip_remove_unsupported_diag_suppression branch March 18, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants