Skip to content

Change default network parameters#6841

Merged
totto82 merged 1 commit intoOPM:masterfrom
totto82:changeNetworkDefaults
Mar 19, 2026
Merged

Change default network parameters#6841
totto82 merged 1 commit intoOPM:masterfrom
totto82:changeNetworkDefaults

Conversation

@totto82
Copy link
Copy Markdown
Member

@totto82 totto82 commented Feb 18, 2026

No description provided.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Feb 18, 2026

jenkins build this failure_report please

1 similar comment
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 2, 2026

jenkins build this failure_report please

@totto82 totto82 force-pushed the changeNetworkDefaults branch from 5c4afbd to 10fd83a Compare March 3, 2026 07:48
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 3, 2026

jenkins build this failure_report please

@GitPaean GitPaean added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Mar 3, 2026
@totto82 totto82 marked this pull request as ready for review March 4, 2026 14:23
@totto82 totto82 requested a review from vkip March 4, 2026 14:23
@vkip
Copy link
Copy Markdown
Member

vkip commented Mar 10, 2026

jenkins build this failure_report please

Copy link
Copy Markdown
Member

@vkip vkip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a variety of models and these parameters improve the performance on the vast majority of them. The exceptions can always explicitly reset the values to the previous default.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 18, 2026

jenkins build this failure_report please

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 18, 2026

Thanks for the testing. I have verified that the test failures are minor. Different tuning leads to changes in the time-stepping. I will update the reference and merge.

@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 18, 2026

jenkins build this update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Mar 18, 2026
Reason: PR OPM/opm-simulators#6841

opm-common     = f7691fbfee5de8de3bbf64c08f025bd85f9c18ac
opm-grid       = 6e620bc2869fca82686f38436b4733a4a5d5b5cb
opm-simulators = 4f82bd5330ee52afa0aa5c13d9f0c5e8b4f00fef

### Changed Tests ###

  * network-01-reroute
  * network-01-reroute_std
  * gsatprod6
@totto82
Copy link
Copy Markdown
Member Author

totto82 commented Mar 18, 2026

jenkins build this opm-tests=1510 please

totto82 added a commit to OPM/opm-tests that referenced this pull request Mar 19, 2026
@totto82 totto82 merged commit 1996dcf into OPM:master Mar 19, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants