Merged
Conversation
akva2
added
the
manual:irrelevant
akva2
force-pushed
the
add_opm-common_option
branch
from
2b19220 to
495cd0b
Compare
bska
approved these changes
Mar 4, 2026
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Save for one small detail, and for which I may be missing some context, this looks good to me. Provided we're doing this change at all, the changes here are fine.
akva2
force-pushed
the
add_opm-common_option
branch
from
495cd0b to
a0003f3
Compare
Member
|
I am a bit confused. What exactly is the use case for this and benefit of it? |
Member
Author
|
It's all rationalized and contextualized in the upstream. |
turn it off build without opm-common
akva2
force-pushed
the
add_opm-common_option
branch
from
a0003f3 to
5378be3
Compare
bska
approved these changes
Mar 9, 2026
Member
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Much appreciated. I'll merge into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turn it off build without opm-common support.
Downstream of OPM/opm-common#5039
Only lightly coupled to the upstream, can be made independent, but then I have to add some code to add the HAVE_OPM_COMMON define instead of getting it from the target, which has to be removed again, so I opted to just do it as a downstream.
Closes #401.