Skip NNCs created by PINCH if one of the cells is collapsed.#935
Open
blattms wants to merge 2 commits intoOPM:masterfrom
Open
Skip NNCs created by PINCH if one of the cells is collapsed.#935blattms wants to merge 2 commits intoOPM:masterfrom
blattms wants to merge 2 commits intoOPM:masterfrom
Conversation
Collaped here means that the points of the top and lower plane all coincide. Later those cells will be treated as inactive in preprocess.c when create the grid topology. They qould presemt numerical problems later anyway. Note that this means that these cells (collapsed but PORV larger than MINPVV) will now be present a barrier for PINCH. Fixes the assertion: flow: ./opm/grid/cpgrid/EntityRep.hpp:121: void Dune::cpgrid::EntityRep<codim>::setValue(int, bool) [with int codim = 0]: Assertion `index_arg >= 0' failed.
blattms
added
the
manual:bugfix
Member
Author
|
jenkins build this please |
Member
Author
|
With this the collapsed cell will prevent creation of an NNC. It might turn out that this is not what we want, but it is certainly way better than a model aborting in an assert. Hence I think this should be merged but we should compare behavior with others. |
Member
|
I'd really like to see some unit tests for this in order to assess the behaviour. |
Member
|
Hei, just a frienldy reminder about the schedule for the release:
If we are backporting this, then we need to make a RC3. |
Member
Author
|
jenkins build this please |
1 similar comment
Member
Author
|
jenkins build this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsed here means that the points of the top and lower plane on the same pillar coincide.
Later those cells will be treated as inactive in preprocess.c and will not be part of the grid. when we create the grid topology. They would present numerical problems later anyway.
Note that this means that these cells (collapsed but PORV larger than MINPVV) will now be present a barrier preventing creation of a PINCH NNC.
Fixes the assertion:
Closes #505