Conversation
|
jenkins build this please |
opm/grid/CpGrid.hpp
Outdated
| /// \param clip_z if true, the grid will be clipped so that the top and bottom will be planar. | ||
| /// \param poreVolume pore volumes for use in MINPV processing, if asked for in deck | ||
| /// | ||
| /// The return value is a list of global indices to the cells which have |
There was a problem hiding this comment.
Any reason not to use /// \return a list ...
There was a problem hiding this comment.
No reason - apart from ignorance; updated now.
opm/grid/CpGrid.hpp
Outdated
| /// | ||
| /// The return value is a list of global indices to the cells which have | ||
| /// been removed in the grid processing due to small pore volume. | ||
| /// Observe that the processEclipseFormat() function only runs on rank |
There was a problem hiding this comment.
... function only returns cell indices on rank 0. vector empty on other ranks.
joakim-hove
force-pushed
the
report-pinched-cells
branch
from
9bc5d79 to
96797d3
Compare
|
jenkins build this please |
Just be aware that this is going to generate at least one regression failure. The current reference solutions are out of date with respect to the master branch of opm-simulators. I'm using OPM/opm-common#2424 to rectify that. |
|
jenkins build this please |
|
Can this be merged? |
|
I am okay this one goes in first. #517 might takes time to review. I will take care of it if something goes wrong by merging this. |
4 participants
Problem with: #519 - only reported cells which were also joined with a pinch. Current version reports nnc pinching and removed cells independently.