Brine density and viscosity with multicomponent salt#5158
Draft
svenn-t wants to merge 2 commits into
Draft
Conversation
svenn-t
added
the
manual:new-feature
Contributor
Author
|
jenkins build this please |
totto82
reviewed
May 19, 2026
Member
totto82
left a comment
totto82
left a comment
There was a problem hiding this comment.
In general, okay. I added some minor comments that should be addressed. I will do some testing and check the final PR before finalizing the review.
svenn-t
force-pushed
the
brine_density_viscosity_multicomp_salt
branch
from
e0e4f77 to
a8856c6
Compare
Member
|
Thanks for the update. The code looks fine. (both this and the other one in opm-common). I still want to test and benchmark this to ensure it does not incur a performance penalty in the standard cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of brine density and viscosity calculations with multicomponent salts from papers Laliberte & Cooper (density) and Laliberte (viscosity).
Depends on PR #5157 which should be merged first. In draft mode until then.
This is a step towards implementation of multicomponent salt in CO2STORE, which will come in other PR(s).