Conversation
|
|
||
| case Opm::EclIO::SummaryNode::Category::Block: | ||
| case Opm::EclIO::SummaryNode::Category::Aquifer: [[fallthrough]]; | ||
| case Opm::EclIO::SummaryNode::Category::Block: [[fallthrough]]; |
There was a problem hiding this comment.
This corrects an oversight where [[fallthrough]] was originally omitted from this case.
|
jenkins build this please |
| @@ -819,6 +820,7 @@ SummaryConfigNode::Category parseKeywordCategory(const std::string& keyword) { | |||
| if (is_special(keyword)) { return Cat::Miscellaneous; } | |||
There was a problem hiding this comment.
None of the keywords checked in is_special currently start with A; is this because aquifer keywords have not been supported, or is this because there are no keywords in SUMMARY that can start with A other than aquifer keywords?
There was a problem hiding this comment.
is this because there are no keywords in SUMMARY that can start with A other than aquifer keywords?
Until proven otherwise I would say it is like this - i.e. all legal SUMMARY keywords starting with 'A' are aquifer keywords.
There was a problem hiding this comment.
is this because aquifer keywords have not been supported, or is this because there are no keywords in SUMMARY that can start with A other than aquifer keywords?
Both. Flow does not create any kind of aquifer-related output—neither to the summary nor to the restart files. We have (very) limited support for reading parameters of the Fetkovich analytic model from a restart file—I needed that in a different project—but writing is unsupported at present. There is a lot of work ahead of us before we can reasonably claim to fully support aquifer workflows.
Writing restart data for aquifers is on my plate.
There was a problem hiding this comment.
Then I will at this time leave is_special() as is.
wito
force-pushed
the
add-aquifer-category
branch
from
8705a7b to
4e08ff7
Compare
|
jenkins build this please |
3 participants
This feature adds
::AquifertoOpm::EclIO::SummaryNode::Category(and, by extension, toOpm::SummaryConfigNode::Category.This PR requires the resolution of #1609.