Skip to content

fixed: make a two-param map template for splitDynMap#1616

Merged
akva2 merged 1 commit intoOPM:masterfrom
akva2:fix_dynmap
Mar 20, 2020
Merged

fixed: make a two-param map template for splitDynMap#1616
akva2 merged 1 commit intoOPM:masterfrom
akva2:fix_dynmap

Conversation

@akva2
Copy link
Copy Markdown
Member

@akva2 akva2 commented Mar 20, 2020

gcc is more forgiving with default template parameters than clang.

Closes #1610

@akva2
Copy link
Copy Markdown
Member Author

akva2 commented Mar 20, 2020

jenkins build this please

@wito
Copy link
Copy Markdown
Contributor

wito commented Mar 20, 2020

@akva2 There is another function; reconstructDynMap:

In file included from /Users/wito/Developer/OPM/opm-common/src/opm/parser/eclipse/Python/Python.cpp:21:
/Users/wito/Developer/OPM/opm-common/opm/parser/eclipse/EclipseState/Schedule/Schedule.hpp:320:17: error: no matching member function for call to 'reconstructDynMap'
                reconstructDynMap(splitvfpprod.first, splitvfpprod.second, vfpprod_tables);
                ^~~~~~~~~~~~~~~~~
/Users/wito/Developer/OPM/opm-common/opm/parser/eclipse/EclipseState/Schedule/Schedule.hpp:468:14: note: candidate template ignored: substitution failure : template template argument has different template parameters than its
      corresponding template template parameter
        void reconstructDynMap(const std::vector<Type>& unique,
             ^
/Users/wito/Developer/OPM/opm-common/opm/parser/eclipse/EclipseState/Schedule/Schedule.hpp:321:17: error: no matching member function for call to 'reconstructDynMap'
                reconstructDynMap(splitvfpinj.first, splitvfpinj.second, vfpinj_tables);
                ^~~~~~~~~~~~~~~~~
/Users/wito/Developer/OPM/opm-common/opm/parser/eclipse/EclipseState/Schedule/Schedule.hpp:468:14: note: candidate template ignored: substitution failure : template template argument has different template parameters than its
      corresponding template template parameter
        void reconstructDynMap(const std::vector<Type>& unique,
             ^

gcc is more forgiving with default template parameters than clang.
@akva2
Copy link
Copy Markdown
Member Author

akva2 commented Mar 20, 2020

jenkins build this please

@wito
Copy link
Copy Markdown
Contributor

wito commented Mar 20, 2020

f0a25e4 builds for me, tests will take some time to see.

Edit: Tests are good as well.

@akva2 akva2 merged commit c57af82 into OPM:master Mar 20, 2020
@akva2 akva2 deleted the fix_dynmap branch March 20, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

not able to build opm-common on mac

2 participants