Remove HAVE_ECL_INPUT and HAVE_ECL_OUTPUT conditionals

[akva2]

opm-common (should) always provide these. closes #1127

[akva2]

jenkins build this opm-material=352 opm-grid=401 opm-models=566 opm-simulators=2072 opm-upscaling=283 please

[alfbr]

Please refrain from merging until we have broad community support for the change.

[totto82]

I agree with @alfbr. I don't think this should be merged before we have a broad discussion about the topic. Including the repository structures as we have it now. As Libecl is gone we may think differently about the topic. If I remember correctly the conditional dependency was to a large degree motivated from the libecl dependency. Currently there are simulators in opm-models that don't depend on opm-common. Maybe we should keep the conditionals dependency on HAVE_ECL_INPUT and instead remove the conditional dependency on opm-common in opm-models? Maybe a hangout on the topic after the release?

[akva2]

jenkins build this opm-material=352 opm-grid=401 opm-models=566 opm-simulators=2072 opm-upscaling=283 please

[joakim-hove]

Since I suggested this in #1127 I would obviously like to merge this; not a big thing - but it will reduce complexity somewhat. I acknowledge the wish for a broader discussion before a decision is made; but that leads to an important point: How do actually reach a consensus on questions like this?

[atgeirr]

How do actually reach a consensus on questions like this?

I support @totto82' suggestion to have a hangout about the topic (future module structure and dependencies) with interested participants after the release.

[joakim-hove]

Time to merge this?

[totto82]

Time to merge this?

I am not against merging this, but I would like to keep the opportunity to include opm-grid opm-material and opm-models as modules using the dune build system. I.e. the downstream changes should be HAVE_ECL_INPUT/OUTPUT--> HAVE_OPM_COMMON, IMO.
I am not sure about opm-grid, but opm-material and opm-models used to build without opm-common using dunecontrol.

[joakim-hove]

OK - we have had 1.5 years with no real objections. Time to revive this.

[blattms]

I am not sure about opm-grid, but opm-material and opm-models used to build without opm-common using dunecontrol

That must have been a time when the buildsystem was replicated in every module. I doubt that it is still the case.

But even if opm-common is needed it might make sense to deactivate ECL (it takes a lot of time and if you don't need it, you might not want to build it ....).