EclipseIO::writeInitial Does Not Output Expanded PVT Tables

[bska]

This issue is to record a deficiency in the contents of the TAB vector of Flow's .INIT file, specifically in the context of ResInsight's PVT plot feature.

If a simulation case uses DISGAS and/or VAPOIL and does not define the undersaturated state for all composition nodes (PVTO keyword) or all pressure nodes (PVTG keyword)—i.e., if at least one set of undersaturated states is defaulted—then the resulting property table in the .INIT file will also not contain those undersaturated states. The immediate cause is that Tables::addPVTO() and Tables::addPVTG() output the raw input tables and don't normalise the tables first.

In principle we would need to perform the same kind of table expansion as is currently undertaken in module OPM-Material's extendPvtoTable_() and extendPvtgTable_() member functions.

One could argue that deep knowledge of ECLIPSE's various table structures should be contained in OPM-Common, as this is the module that most directly deals with input and output of ECLIPSE-style data files. I am not currently proposing that we move the code in question from material to common now, especially not since the 2019.04 release is imminent, but I would like to pose the question for a later time.

[bska]

As a follow-up comment, I am currently working in this area and will submit a pull request Soon[tm] that will make the contents of the property tables structurally compatible with ECLIPSE's conventions. This forthcoming PR will however also suffer from the deficiency recorded in this issue.