-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix XML Encoding and decoding of Matrix Element in Variant to conform to spec #3053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
+ Coverage 57.00% 57.03% +0.03%
==========================================
Files 357 357
Lines 68916 68951 +35
Branches 14154 14156 +2
==========================================
+ Hits 39285 39328 +43
- Misses 25385 25388 +3
+ Partials 4246 4235 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrsuciu
approved these changes
Apr 15, 2025
marcschier
approved these changes
Apr 15, 2025
13 tasks
mrsuciu
added a commit
that referenced
this pull request
Apr 15, 2025
… to spec (#3053) (#3054) * Fix XML Encoding and decoding to conform to spec * fix test on linux * fix typo * Add missing DataValue & DiagnosticInfo Array Types Co-authored-by: romanett <[email protected]>
mregen
pushed a commit
to mregen/UA-.NetStandard
that referenced
this pull request
May 16, 2025
… to spec (OPCFoundation#3053) * Fix XML Encoding and decoding to conform to spec * fix test on linux * fix typo * Add missing DataValue & DiagnosticInfo Array Types
mrsuciu
added a commit
that referenced
this pull request
Jun 23, 2025
* Update version.json (#3050) * Fix XML Encoding and decoding of Matrix Element in Variant to conform to spec (#3053) (#3054) * Fix XML Encoding and decoding to conform to spec * fix test on linux * fix typo * Add missing DataValue & DiagnosticInfo Array Types Co-authored-by: romanett <[email protected]> * Return NodeSet to 1.05.04. * Remove OptionalPlaceholders on instances. * Fix duplicate pragas. * Fix glitches in generated files. --------- Co-authored-by: Suciu Mircea Adrian <[email protected]> Co-authored-by: romanett <[email protected]> Co-authored-by: Randy Armstrong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A Variant containing a multi dimensional array needs to be encoded with a specified syntax.
The XML Encoder / Decoder of the stack did only follow this Spec for the ReadArray / WriteArray implementation but not ReadVariant/WriteVariant
https://reference.opcfoundation.org/Core/Part6/v105/docs/5.3.1.17
This PR fixes JsonEncoder & Decoder & introduces a test case.
#3045
Related Issues
Types of changes
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...