Fuzz rust cov v2 #5613
Closed
Fuzz rust cov v2 #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because both seem incompatible for now
Closed
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2025
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2025
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2025
To avoid overhead of copies during syncs, compress the local stats table. Previously all counters had 2 64bit ints: one for the value, one to track the number of times the counter was updated. The updates field was only used for counters of type "average" however. Since only a few average counters were in use, this effectively meant that almost half of the space used for the table was wasted. This patch reduces `StatsLocalCounter` to a single i64. Regular counters simply use this directly by using their id as an index into the table. For avg counters the logic is similar, however they effectively use 2 indexes, idx and idx+1. The value is at `idx`, the updates are at `idx + 1`. Ticket: OISF#5613.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 2, 2025
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 2, 2025
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 2, 2025
To avoid overhead of copies during syncs, compress the local stats table. Previously all counters had 2 64bit ints: one for the value, one to track the number of times the counter was updated. The updates field was only used for counters of type "average" however. Since only a few average counters were in use, this effectively meant that almost half of the space used for the table was wasted. This patch reduces `StatsLocalCounter` to a single i64. Regular counters simply use this directly by using their id as an index into the table. For avg counters the logic is similar, however they effectively use 2 indexes, idx and idx+1. The value is at `idx`, the updates are at `idx + 1`. Ticket: OISF#5613.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4125
Describe changes:
Modifies #5595 with
_BSD_SOURCEto get to useDT_REGTL;DR
To get coverage report including rust with oss-fuzz, we will also need rustc changes, and oss-fuzz changes
To get this manually is possible, cf below
To get coverage, I compile with
I also run in rust subdirectory
to get the absolute file paths for suricata's crate, so that llvm-cov can generate a nice report
You need some fresh rust nightly compiler and llvm 10
For LLVM 11 and 12, rust compiler should be just ready cf rust-lang/rust#79365