Refactor duplicated RenderSystem capability initialization #3478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Four RenderSystem implementations (Tiny, GL, GL3Plus, GLES2) contained identical 9-line blocks for capability initialization, each marked with TODO comments about the duplication.
Changes
Added
RenderSystem::initialiseRenderSystemCapabilities()protected helper method encapsulating the common pattern:createRenderSystemCapabilities()mCurrentCapabilitiesfrommRealCapabilitiesif custom capabilities disabledRenderSystemCapabilitiesCreatedeventRefactored all four implementations to call the helper method
Before:
After:
initialiseRenderSystemCapabilities(win);Net: -17 lines, removed 4 TODO markers.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
download.savannah.gnu.orgcmake -DCMAKE_BUILD_TYPE=Debug -DOGRE_BUILD_TESTS=OFF -DOGRE_BUILD_RENDERSYSTEM_TINY=TRUE -DOGRE_BUILD_RENDERSYSTEM_GL=TRUE -DOGRE_BUILD_RENDERSYSTEM_GL3PLUS=TRUE -DOGRE_BUILD_RENDERSYSTEM_GLES2=TRUE -DOGRE_BUILD_DEPENDENCIES=TRUE ..(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.