[18.0][MIG] base_multi_image: Migration to 18.0 by BhaveshHeliconia · Pull Request #3209 · OCA/server-tools

BhaveshHeliconia · 2025-02-24T11:54:43Z

No description provided.

flotho · 2025-08-18T14:10:26Z

Hi @BhaveshHeliconia

Thanks for this PR, any chance to rebase ?
Regards

BhaveshHeliconia · 2025-08-19T10:15:58Z

@flotho : It's done. Thanks

flotho · 2025-08-19T11:19:52Z

Wonderful, CI/CD is green, we'll be able to go to Review

legalsylvain

Fonctional test. Works like a charm.

@flotho Did you have the time to review this PR ?

ivs-cetmix · 2026-01-11T14:50:00Z

Hey @BhaveshHeliconia thank you for your contribution! Could you please fix the pre-commit and rebase your branch?

See OCA/product-attribute#135 (comment).

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

…_for_submodules to not use image_ids

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_multi_image/

Currently translated at 100.0% (33 of 33 strings) Translation: server-tools-16.0/server-tools-16.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_multi_image/it/

BhaveshHeliconia · 2026-01-12T04:51:39Z

@ivs-cetmix : Done. Thanks!

ivs-cetmix · 2026-01-12T10:25:27Z

Thank you @BhaveshHeliconia !
@flotho would appreciate your review.

ivs-cetmix · 2026-01-12T10:31:19Z

@BhaveshHeliconia also would be great if you could add some simple tests so we could have one more CI checks green. I think an assertRaises here and nearby will do the job.

BhaveshHeliconia · 2026-01-12T12:57:23Z

@ivs-cetmix : Done. Thanks!

flotho · 2026-03-03T15:37:51Z

+        """Allow to download an image and cache it by its URL."""
+        if url:
+            try:
+                (filename, header) = urlretrieve(url)


Hi, thaks for this PR, we're freuently facing 403 errors.
Looks like it coming from https://scrape.do/blog/python-requests-403-forbidden/
I've tested with simple cli query and adding headers works perfectly.
Is there any chance you add headers in your query.
For example it could be Odoo-agent ith web.base.url and default english language.

Thanks

Hi, thanks for the suggestion.
I've updated the query to include the headers as suggested. Could you please take another look when you get a chance?

flotho

Hi,

A great thanks for your reactivity.
Your latest commit solve 403 frequent issues !
tested in production
LGTM

OCA-git-bot · 2026-03-06T11:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

DorianMAG

Thx for this work.
Functional test ok
LGTM

rvalyi · 2026-03-06T11:43:20Z

/ocabot merge nobump

OCA-git-bot · 2026-03-06T11:43:27Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3209-by-rvalyi-bump-nobump, awaiting test results.

OCA-git-bot · 2026-03-06T12:00:35Z

Congratulations, your PR was merged at bad4c91. Thanks a lot for contributing to OCA. ❤️

BhaveshHeliconia mentioned this pull request Feb 24, 2025

[18.0][MIG] stock_lot_multi_image: Migration to 18.0 OCA/stock-logistics-warehouse#2272

Open

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from 5cd2f62 to d00e3e8 Compare February 24, 2025 12:12

BhaveshHeliconia mentioned this pull request Feb 24, 2025

Migration to version 18.0 #3047

Open

40 tasks

flotho mentioned this pull request Aug 18, 2025

[MIG][18.0] connector_prestashop OCA/connector-prestashop#187

Closed

3 tasks

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from d00e3e8 to 27e7577 Compare August 19, 2025 10:02

JulienMartinez mentioned this pull request Sep 24, 2025

[18.0][MIG] product_multi_image: Migration to 18.0 OCA/product-attribute#2074

Open

legalsylvain approved these changes Dec 19, 2025

View reviewed changes

yajo and others added 19 commits January 12, 2026 09:56

Split model in abstract & concrete.

65215cd

Extend model example.

1753c57

Tenames and typos.

43b594a

No default value for storage.

84d31c3

Do not require a name.

0d54aa2

Add sequence to images.

c5755fe

Reduce methods.

1538f32

Cache images' URL.

c098e49

Remove wrong copyright.

cf047e0

Add known issues section.

5e644f4

Fix bug that made previous images to disappear.

b75edcf

See OCA/product-attribute#135 (comment).

[MIG][9.0] base_multi_image

b73c472

[FIX] base_multi_image - New storage backend 'Filestore' to link an e…

aa5d453

…xisting attachment record + Fix the 'pre_init_hook_for_submodules()' hook to extract the images from the ir_attachment table for binary fields initialized with the 'attachment=True' parameter

[IMP] base_multi_image - Select only images as attachments

02d5d7d

[FIX] base_multi_image - Clean up + updated comments

3bc738f

[FIX] base_multi_image - Make validation error messages translatable

f0a073e

[FIX] base_multi_image - Fix method name

b99880a

Use v9 ormcache.

aeb12c0

Add a reference field to get to the owner with 1 click.

9cc73d4

IJOL and others added 8 commits January 12, 2026 09:56

[UPD] base_multi_image removed unused params, revamped post_init_hook…

dce7f8a

…_for_submodules to not use image_ids

[UPD] Update base_multi_image.pot

015d812

Update translation files

9958719

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_multi_image/

Translated using Weblate (Italian)

d0a2118

Currently translated at 100.0% (33 of 33 strings) Translation: server-tools-16.0/server-tools-16.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_multi_image/it/

Translated using Weblate (Italian)

6b0a4b5

Currently translated at 100.0% (33 of 33 strings) Translation: server-tools-16.0/server-tools-16.0-base_multi_image Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_multi_image/it/

[FIX] base_multi_image: Attribute Error

776a2b2

[BOT] post-merge updates

62d26d8

[IMP] base_multi_image: pre-commit auto fixes

ed768d6

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from eb0df57 to a81d64e Compare January 12, 2026 04:27

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from c2271ea to 31703e4 Compare January 12, 2026 12:56

flotho suggested changes Mar 3, 2026

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from 31703e4 to 54093a8 Compare March 6, 2026 05:45

[MIG] base_multi_image: Migration to 18.0

cf2f689

BhaveshHeliconia force-pushed the 18.0-mig-base_multi_image branch from 54093a8 to cf2f689 Compare March 6, 2026 06:19

flotho approved these changes Mar 6, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 6, 2026

DorianMAG approved these changes Mar 6, 2026

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Mar 6, 2026

OCA-git-bot merged commit 3c39ee1 into OCA:18.0 Mar 6, 2026
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 6, 2026

Uh oh!

Conversation

BhaveshHeliconia commented Feb 24, 2025

Uh oh!

flotho commented Aug 18, 2025

Uh oh!

BhaveshHeliconia commented Aug 19, 2025

Uh oh!

flotho commented Aug 19, 2025

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

ivs-cetmix commented Jan 11, 2026

Uh oh!

BhaveshHeliconia commented Jan 12, 2026

Uh oh!

ivs-cetmix commented Jan 12, 2026

Uh oh!

ivs-cetmix commented Jan 12, 2026

Uh oh!

BhaveshHeliconia commented Jan 12, 2026

Uh oh!

flotho Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

flotho left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 6, 2026

Uh oh!

DorianMAG left a comment

Choose a reason for hiding this comment

Uh oh!

rvalyi commented Mar 6, 2026

Uh oh!

OCA-git-bot commented Mar 6, 2026

Uh oh!

Uh oh!

OCA-git-bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants