Skip to content

Add 19.0 on OCB Sync #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

Add 19.0 on OCB Sync #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_gen_addon_readme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,10 @@ def test_rst_error(tmp_path):
cmd + opts, stderr=subprocess.STDOUT, universal_newlines=True
)
except subprocess.CalledProcessError as e:
assert "Title level inconsistent" in e.output
assert (
Copy link
Member Author

@etobella etobella Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not happy with this change, but different errors were raised for each python version 😢

Copy link
Contributor

@rousseldenis rousseldenis Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etobella and testing python version would add more code noise. So, that's the best for now

"Inconsistent title style" in e.output
or "Title level inconsistent" in e.output
)
else:
assert False, "A rst syntax error should have been detected."

Expand Down
2 changes: 1 addition & 1 deletion tools/ocb-sync.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

ODOO="[email protected]:/odoo/odoo.git"
OCB="[email protected]:/OCA/OCB.git"
BRANCHES="18.0 17.0 16.0 15.0"
BRANCHES="19.0 18.0 17.0 16.0 15.0"
Copy link
Member

@sbidoul sbidoul Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove 15? it's very unlikely to evolve by now.

Copy link
Member Author

@etobella etobella Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, Odoo will start maintaining 5 versions, isn't it?

Copy link
Member

@StefanRijnhart StefanRijnhart Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Only on Odoo.sh" whatever that means

GITDIR="/var/tmp/git"
PUBDIR="/var/tmp/ocb-nightly"
BUILDDIR="/var/tmp/ocb-build"
Expand Down