[18.0][IMP] account_payment_return: Allow select distinct journal items. Refactor #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seful using intermediate accounts TT35080
carlos-lopez-tecnativa
suggested changes
Nov 24, 2025
Contributor
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
Code review, LGTM, please check the CI
… _check_duplicate_move_line
Contributor
Author
|
Fixed the test that was incorrectly done before this PR; it did not give an error, but it was wrong... |
Contributor
Author
|
FYI @sergio-teruel |
carlos-lopez-tecnativa
suggested changes
Nov 25, 2025
Contributor
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
I think you need to change the domain here as well. Is there any reason not to do it?
https://github.com/Tecnativa/account-payment/blob/2fa6cc8a062912aef388789227cff085e156f4fa/account_payment_return/views/payment_return_view.xml#L96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW-port #510
@Tecnativa TT59230
ping @victoralmau @carlos-lopez-tecnativa