[19.0][MIG] account_payment_term_extension: Migration to 19.0 by pablo-cort-s73 · Pull Request #903 · OCA/account-payment

pablo-cort-s73 · 2025-11-11T16:23:54Z

The module version was updated to 19.0.1.0.0 in the manifest.
In the account_payment_term_holiday model, the check_holiday constraint was refactored to use the new odoo.fields.Domain API and marked as @api.private.
Tests were modified to create the necessary data programmatically instead of relying on external data records, following new best practices.

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[UPD] Update account_payment_term_extension.pot

Closes OCA#527

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/es/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/pt_BR/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr_CH/

Currently translated at 85.7% (24 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/hr/

…s precision_digits

Currently translated at 100.0% (28 of 28 strings) Translation: account-payment-13.0/account-payment-13.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-13-0/account-payment-13-0-account_payment_term_extension/es_AR/

…ion in payment term lines

…re resilient * A `account.journal` record was being searched and used to create invoices, even though it was not necessary. This introduced the problem of finding more than one record that satisfied the search query, breaking the test for a singleton error. This removes the need for that. * Extract a method for creating the invoice. * Don't depend on variable year for tests. TT27288 Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

…F part

…and weeks fix computing months and weeks

reformat

add test months

black

Currently translated at 100.0% (34 of 34 strings) Translation: account-payment-14.0/account-payment-14.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_term_extension/es_AR/

odooNextev · 2026-01-16T13:25:01Z

Hi @pablo-cort-s73,
we opened an issue for a major issue in v18.0 that appears to be impacting this migration as well: #919
I created a PR to solve it and it's close to merge: #920

pablo-cort-s73 · 2026-01-19T07:31:50Z

Of course @odooNextev right now I add the commit to the migration. Thanks a lot

…st and fix tests

Borruso

LGTM

pablo-cort-s73 · 2026-02-23T07:15:47Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

odooNextev · 2026-02-23T10:41:39Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

Code looks good, but I cannot try it on runboat cause it doesn't work.

pablo-cort-s73 · 2026-02-23T16:19:42Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

Code looks good, but I cannot try it on runboat cause it doesn't work.

@odooNextev Runboat on. 👍

odooNextev

LGTM
Issue solved: #919

svilaLevel4

LGTM

mmircoli-nexapp · 2026-05-05T07:28:00Z

is it ready to merge?

mmircoli-nexapp · 2026-05-05T15:15:39Z

@pedrobaeza is it possible merge?

Thank you so much in advance for your help

pedrobaeza · 2026-05-05T15:45:18Z

@etobella has requested changes.

etobella · 2026-05-05T15:50:58Z

/ocabot merge nobump

pedrobaeza · 2026-05-05T15:51:04Z

/ocabot merge nobump

OCA-git-bot · 2026-05-05T15:51:10Z

On my way to merge this fine PR!
Prepared branch 19.0-ocabot-merge-pr-903-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2026-05-05T15:51:13Z

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-903-by-pedrobaeza-bump-nobump, awaiting test results.

pedrobaeza · 2026-05-05T15:52:37Z

Cancelling my merge 🤦

OCA-git-bot · 2026-05-05T15:53:19Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-903-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot · 2026-05-05T15:55:47Z

Congratulations, your PR was merged at 8a69af1. Thanks a lot for contributing to OCA. ❤️

Alexis de Lattre and others added 30 commits November 11, 2025 15:27

Port module payment_term_rounding to v8 and rename to account_payment…

ab793f4

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

Migration V9 account_payment_term_extension

0635abb

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[IMP] account_payment_term_extension: Switch company

4eb1a03

Port account_payment_term_extension to v10

db17b8c

[UPD] Module account_payment_term_extension, added holidays management

98e2d5a

[MIG] account_payment_term_extension: Migration to 11.0

4a84d05

[MIG] account_payment_term_extension: Migration to 12.0

7c10175

[UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension: Add payment_days to view

bb85d93

Closes OCA#527

12.0 [FIX] the sequential line was not visible

2c811df

[IMP] account_payment_term_extension: black, isort, prettier

0bfeb5f

[MIG] account_payment_term_extension: Migration to 13.0

b5cf7f3

[FIX] account_payment_term_extension: bad use of precision_rounding v…

4a3f0bb

…s precision_digits

[IMP] account_payment_term_extension: Add amount_untaxed to value opt…

7804f80

…ion in payment term lines

[IMP] account_payment_term_extension: black, isort, prettier

f0fbc7e

[MIG+IMP] account_payment_term_extension: Migration to 14.0

7fc9b3a

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension missing standard option into ELI…

323c8a0

…F part

[ADD][14.0] account_payment_term_discount

a6fc8be

[14.0] [account_payment_term_extension] [FIX] error computing months …

a09bb8a

…and weeks fix computing months and weeks

reformat

6ca8628

reformat

test months

50f3cb9

add test months

black

9a51f43

black

Added translation using Weblate (French (France))

178b237

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 08c7679 to 17e6b27 Compare November 28, 2025 06:55

[FIX] account_payment_term_extension: put end of month calculation la…

1c3443c

…st and fix tests

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 17e6b27 to 9fd4dd3 Compare January 19, 2026 07:39

Borruso approved these changes Feb 22, 2026

View reviewed changes

[MIG] account_payment_term_extension: Migration to 19.0

ce4e5b5

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 9fd4dd3 to ce4e5b5 Compare February 23, 2026 16:17

odooNextev approved these changes Feb 24, 2026

View reviewed changes

svilaLevel4 approved these changes Apr 20, 2026

View reviewed changes

etobella approved these changes May 5, 2026

View reviewed changes

OCA-git-bot added the approved label May 5, 2026

OCA-git-bot added the bot is merging ⏳ label May 5, 2026

OCA-git-bot removed the bot is merging ⏳ label May 5, 2026

OCA-git-bot merged commit 30f0c4f into OCA:19.0 May 5, 2026
7 checks passed

OCA-git-bot added the merged 🎉 label May 5, 2026

mmircoli-nexapp mentioned this pull request May 5, 2026

[19.0][MIG] l10n_it_riba_oca: Migration to 19.0 OCA/l10n-italy#5090

Open

Uh oh!

Uh oh!

Conversation

pablo-cort-s73 commented Nov 11, 2025

Uh oh!

odooNextev commented Jan 16, 2026

Uh oh!

pablo-cort-s73 commented Jan 19, 2026

Uh oh!

Borruso left a comment

Choose a reason for hiding this comment

Uh oh!

pablo-cort-s73 commented Feb 23, 2026

Uh oh!

odooNextev commented Feb 23, 2026

Uh oh!

pablo-cort-s73 commented Feb 23, 2026

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

svilaLevel4 left a comment

Choose a reason for hiding this comment

Uh oh!

mmircoli-nexapp commented May 5, 2026

Uh oh!

mmircoli-nexapp commented May 5, 2026

Uh oh!

pedrobaeza commented May 5, 2026

Uh oh!

etobella commented May 5, 2026

Uh oh!

pedrobaeza commented May 5, 2026

Uh oh!

OCA-git-bot commented May 5, 2026

Uh oh!

OCA-git-bot commented May 5, 2026

Uh oh!

pedrobaeza commented May 5, 2026

Uh oh!

OCA-git-bot commented May 5, 2026

Uh oh!

Uh oh!

OCA-git-bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants