[18.0] [MIG] account_move_line_payment: Migration to 18.0 #892
Conversation
New module that simplifies the use case of registering partial invoice payments. @moduon MT-5071
Currently translated at 100.0% (5 of 5 strings) Translation: account-payment-16.0/account-payment-16.0-account_move_line_payment Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_move_line_payment/it/
Currently translated at 100.0% (5 of 5 strings) Translation: account-payment-16.0/account-payment-16.0-account_move_line_payment Translate-URL: https://translation.odoo-community.org/projects/account-payment-16-0/account-payment-16-0-account_move_line_payment/pt_BR/
RedaKarimi
changed the title
RedaKarimi
force-pushed
the
18.0-mig-account_move_line_payment
branch
from
aa3aef6 to
bfe02a9
Compare
|
/ocabot migration account_move_line_payment |
|
Sorry @mmircoli-nexapp you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@pedrobaeza is it ok the pull request? |
pedrobaeza
changed the title
|
The PR title was not OK. Changed. Commit history and formal process seems OK. Now reviewers should confirm the correct code and functional behavior. /ocabot migration account_move_line_payment |
| - Invoicing users should be able too. | ||
| - A good improvement would be to display *Next due date* in invoices views. | ||
| - Also to allow somehow paying only overdue payments when using the register payment wizard. | ||
| - This feature already exists in Odoo 17 under *Invoicing > Customers/Vendors > Amounts to settle*, so there's no need to forward-port this module. |
There was a problem hiding this comment.
mmm but is not avaible in due dates menu
There was a problem hiding this comment.
This module add the function on voice menu payments and Due list
There was a problem hiding this comment.
You're right. Then let's remove this roadmap item
There was a problem hiding this comment.
ok I contact the author to remove the roadmap and squash the commit
|
Hello folks! We will not use this module for v17+ because Odoo includes the part of it that we need: 
|
which module implement this action?? |
do you use some module? I try to check on runbot 18.0 and I don't find this voice of Menu |
this module add the function here And without the module the function is not avaible |
I agree your point of view, however if you have more deadlines you need to register only 1 one and not alle total of invoice |
|
Core behavior was added to v17, but in v18 has been removed again. MT-12596 |
| # from . import wizards | ||
| # from . import controllers | ||
| # from . import report | ||
| # from .hooks import pre_init_hook, post_load, post_init_hook, uninstall_hook |
There was a problem hiding this comment.
separated commit or We can fix and squash?
There was a problem hiding this comment.
fixup under Migration 18.0 commit, but I don't see the Migration to 18.0 commit.
Can you do again all the process to separate the pre-commit fixes and the proper Migration to 18.0 commit?
You can follow this guide step by step to leave a perfect commit history: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#how-to
The commit history should be:
# Leave this commit as it is. It's not a translation
[ADD] account_move_line_payment: simple partial overdue payment flow
# Fixup this commit (translation related)
[UPD] Update account_move_line_payment.pot
# Fixup this commit (translation related)
Added translation using Weblate (Italian)
# Fixup this commit (translation related)
Translated using Weblate (Italian)
# Fixup this commit (translation related)
Added translation using Weblate (Portuguese (Brazil))
# Fixup this commit (translation related)
Translated using Weblate (Portuguese (Brazil))
# The module with 16.0 version as it is, code shouldn't work here. It's just to prevent auto-commit extra pollution in the next commit
[IMP] account_move_line_paymnet: pre-commit auto fixes
# In this commit you should modify all the logic and remove all the unnecessary code. All the subsequent modifications should be "fixup" into this commit
[MIG] account_move_line_paymnet: Migration to 18.0You can try to "fixup" all the commits that have something like "translation".
There was a problem hiding this comment.
thank you for the feedback I will do
Gelojr
left a comment
Gelojr
left a comment
There was a problem hiding this comment.
Congratulations on the great work @RedaKarimi ! The following tests were performed successfully:
Test 1: Verified that the “Overdue” filter in Journal Items correctly lists only receivable lines due today or earlier and not yet matched.
Test 2: Checked that registering a payment from Journal Items reconciles only the selected overdue line and leaves future ones pending.
Test 3: Confirmed that the same behavior applies to payable lines, which are correctly reconciled and disappear from the overdue list after payment.
|
Hello @RedaKarimi , Thank you for this migration, please could you review comments from @Shide ? Thank you |
|
@RedaKarimi can you apply #892 (comment) changes? |
Hi my collegue is busy in this period, if you want do a PR to our branch or do a super seed for us there is no problem |
|
Please check out #913 for next reviews |
12 participants
No description provided.