Skip to content

[18.0] [MIG] analytic_partner: Migration to 18.0 #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0] [MIG] analytic_partner: Migration to 18.0 #823

wants to merge 1 commit into from

Conversation

@AmalBenAissa
Copy link

@AmalBenAissa AmalBenAissa commented Aug 26, 2025

Migration module analytic_partner to version 18.0

@AmalBenAissa AmalBenAissa mentioned this pull request Aug 26, 2025
Open
16 tasks
@DorianMAG
Copy link

DorianMAG commented Aug 28, 2025

Hi @AmalBenAissa
Can you squash your commits plz?

flotho
flotho suggested changes Aug 28, 2025
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've installed the module here http://oca-account-analytic-18-0-pr823-611933295916.runboat.odoo-community.org/odoo/action-286 but I'm not able to reach the analytic lines.
could you elaborate the README and the process.
Otherwise, the code LGTM

analytic_partner/README.rst Outdated
Usage
=====

1. Go to **Invoicing > Accounting > Management > Analytic Items**.
Copy link
Member

@flotho flotho Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here

Copy link

@luisDIXMIT luisDIXMIT Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, Management section doesn't exist.

Copy link
Author

@AmalBenAissa AmalBenAissa Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated this instruction in readme file

flotho
flotho suggested changes Aug 28, 2025
View reviewed changes
analytic_partner/views/res_partner_views.xml
type="action"
name="%(act_analytic_cost_revenue)d"
icon="fa-usd"
string="Cost/Revenue"
Copy link
Member

@flotho flotho Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add default values in the context so that create will be eased during the creation

@AmalBenAissa AmalBenAissa force-pushed the 18.0-mig-analytic_partner branch from 6119332 to ff26ba1 Compare August 28, 2025 09:35
@AmalBenAissa
Copy link
Author

AmalBenAissa commented Aug 28, 2025

Hi @AmalBenAissa Can you squash your commits plz?

hello @DorianMAG thanks for the request that is done

luisDIXMIT
luisDIXMIT approved these changes Aug 28, 2025
View reviewed changes
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and LGTM, just change the PR title to "[18.0] [MIG] analytic_partner: Migration to 18.0". It's a convenion to easily search it and identify.

@AmalBenAissa AmalBenAissa changed the title 18.0 mig analytic partner [18.0] [MIG] analytic_partner: Migration to 18.0 Aug 29, 2025
[MIG] analytic_partner : Migration to 18.0
9676278 
[MIG] analytic_partner : Migration to 18.0

[MIG] analytic_partner : Migration to 18.0

update readme file
@AmalBenAissa AmalBenAissa force-pushed the 18.0-mig-analytic_partner branch from d2168b2 to 9676278 Compare August 29, 2025 10:37
flotho
flotho approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat.
Doc is Ok, y bad
LGTM

@flotho
Copy link
Member

flotho commented Aug 29, 2025

ping @OCA/accounting-maintainers any chance to have a merge here ?

DorianMAG
DorianMAG approved these changes Aug 29, 2025
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test.
LGTM
Thx for this work

Saran440
Saran440 suggested changes Sep 5, 2025
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check commit, It must have history commit.

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@Saran440 Saran440 Saran440 requested changes

@flotho flotho flotho approved these changes

@DorianMAG DorianMAG DorianMAG approved these changes

@luisDIXMIT luisDIXMIT luisDIXMIT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs fixing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AmalBenAissa @DorianMAG @flotho @Saran440 @luisDIXMIT @grindtildeath @OCA-git-bot