fix package description so it doesn't collide with GenerateAssemblyInfo Task #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit21agrawal
requested review from
PatoBeltran,
dtivel,
emgarten,
jainaashish,
mishra14,
nkolev92 and
zhili1208
nkolev92
approved these changes
Aug 14, 2017
rohit21agrawal
force-pushed
the
dev-ragrawal-packdescription
branch
from
97d558f to
0f477be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: NuGet/Home#5374
Pack.targets sets the default value of Description property to "Package Description":
<Description Condition="'$(Description)'==''">Package Description</Description>If the project doesn't set Description this default value ends up in its AssemblyDescriptionAttribute:
<AssemblyAttribute Include="System.Reflection.AssemblyDescriptionAttribute" Condition="'$(Description)' != '' and '$(GenerateAssemblyDescriptionAttribute)' == 'true'">