pack pri file for inner builds in multi-targeting scenarios#1185
Merged
rohit21agrawal merged 1 commit intodevfrom Mar 2, 2017
Merged
pack pri file for inner builds in multi-targeting scenarios#1185rohit21agrawal merged 1 commit intodevfrom
rohit21agrawal merged 1 commit intodevfrom
Conversation
emgarten
approved these changes
Feb 10, 2017
| </MSBuild> | ||
| </Target> | ||
|
|
||
| <!--Projects with target framework like UWP, Win8, wpa81 produce a Pri file |
| <!--Projects with target framework like UWP, Win8, wpa81 produce a Pri file | ||
| in their bin dir. This Pri file is not included in the BuiltProjectGroupOutput, and | ||
| has to be added manually here.--> | ||
| <Target Name="_AddPriFileToPackBuildOutput" |
Member
There was a problem hiding this comment.
Looks like you could condition this target on IncludeProjectPriFile and checking if ProjectPriFullPath is non-empty. Not sure it would actually save much for perf however.
rohit21agrawal
force-pushed
the
dev-ragrawal-prifix
branch
from
6fa1ce3 to
b8ceb2f
Compare
clairernovotny
pushed a commit
to novotnyllc/MSBuildSdkExtras
that referenced
this pull request
Feb 18, 2017
rohit21agrawal
pushed a commit
that referenced
this pull request
Mar 10, 2017
|
nuget pack command does not generate .pri file for UWP platform when muvtitargetting is used .Looks like the changes that are merged here have not been published in latest nuget . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : NuGet/Home#4136
The last fix for adding pri files to get packed in UWP apps worked for single framework scenarios only because the pri file was being added in the outer build.
This fix makes sure that multi-targeting scenarios work too - pri files get added if you have
TargetFrameworkorTargetFrameworksdefined in your project.CC: @rrelyea @emgarten @alpaix @mishra14 @jainaashish @zhili1208 @nkolev92