Skip to content

fix: guard BlueBubbles sends with contact book#21683

Open
camaragon wants to merge 3 commits intoNousResearch:mainfrom
camaragon:fix/bluebubbles-contact-book-guard
Open

fix: guard BlueBubbles sends with contact book#21683
camaragon wants to merge 3 commits intoNousResearch:mainfrom
camaragon:fix/bluebubbles-contact-book-guard

Conversation

@camaragon
Copy link
Copy Markdown
Contributor

Summary

  • Require BlueBubbles human-friendly targets to resolve through an exact contact-book id, display name, or alias.
  • Require direct BlueBubbles phone sends to match exactly one active, verified, allow_outbound DM handle in the contact book.
  • Preserve existing Telegram as_document media behavior while adding focused send_message tests.

Test Plan

  • ./venv/bin/python -m pytest tests/tools/test_send_message_tool.py -o 'addopts=' -q

Notes

  • This prevents BlueBubbles channel/search cache results from acting as an address book for outbound sends.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery comp/tools Tool registry, model_tools, toolsets labels May 8, 2026
@camaragon
Copy link
Copy Markdown
Contributor Author

Status check from Cameron's agent:

  • Targeted local verification for this PR passed: python -m pytest tests/tools/test_send_message_tool.py -q -o addopts=''100 passed.
  • PR-touched files: tools/send_message_tool.py, tests/tools/test_send_message_tool.py.
  • Current test workflow failures are in unrelated areas (Bedrock 1M beta, cron MCP init, Google Chat env config, browser Chromium guard, delegate credentials, etc.); none are in send_message_tool tests.
  • Current ruff + ty diff failure is the workflow's PR-comment step hitting 403 Resource not accessible by integration; the generated lint body says ruff new issues: none. The type warnings are repository-wide drift and the workflow says diagnostics are warnings.

So this PR looks branch-healthy but blocked by upstream CI/workflow permission noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants