fix(approval): add cron allowlist mode#21034
Open
LeonSGP43 wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(approval): add cron allowlist mode#21034LeonSGP43 wants to merge 1 commit intoNousResearch:mainfrom
LeonSGP43 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
alt-glitch
added
type/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20984.
Adds an explicit
approvals.cron_mode: allowlistmode for unattended cron sessions.approvestill allows all non-hardline dangerous commands,denyblocks dangerous cron commands, andallowlistonly permits dangerous command patterns already present incommand_allowlist.This keeps the hardline blocklist unconditional and updates both approval entry points used before terminal execution:
check_dangerous_command()check_all_command_guards()Tests
scripts/run_tests.sh tests/tools/test_cron_approval_mode.py tests/tools/test_hardline_blocklist.py -k 'cron or hardline'(122 passed, 4 warnings)python -m py_compile tools/approval.py hermes_cli/config.py tests/tools/test_cron_approval_mode.pygit diff --check