Skip to content

fix: validate cron no-agent update invariants#21031

Open
sgtworkman wants to merge 1 commit intoNousResearch:mainfrom
sgtworkman:fix/cron-no-agent-validation
Open

fix: validate cron no-agent update invariants#21031
sgtworkman wants to merge 1 commit intoNousResearch:mainfrom
sgtworkman:fix/cron-no-agent-validation

Conversation

@sgtworkman
Copy link
Copy Markdown

Summary

  • Enforce cron no-agent update invariants at the jobs data layer
  • Reject clearing script while no_agent=True
  • Reject toggling promptless/skill-less no-agent jobs back into empty agent mode
  • Align cron script empty-output test with the current silent-skip behavior
  • Replace docs ASCII box diagrams with Mermaid so diagram lint stays green

Test Plan

  • scripts/run_tests.sh tests/cron/test_cron_no_agent.py -q (RED before fix: 4 new tests failed)
  • scripts/run_tests.sh tests/cron -q
  • cd website && PATH="$HOME/Library/Python/3.14/bin:$HOME/.local/bin:$PATH" npm run lint:diagrams
  • cd website && npm run build (passes; existing broken-link warnings remain)

Notes

Follow-up to #19709. This closes the lifecycle sharp edge where a valid no-agent watchdog could be updated into no_agent=True with no script, or into agent mode with no prompt/skills.

@sgtworkman sgtworkman force-pushed the fix/cron-no-agent-validation branch from 2cdfa3e to d204b2c Compare May 7, 2026 04:53
@alt-glitch alt-glitch added type/bug Something isn't working comp/cron Cron scheduler and job management type/docs Documentation improvements P2 Medium — degraded but workaround exists and removed type/docs Documentation improvements labels May 7, 2026
@sgtworkman
Copy link
Copy Markdown
Author

CI workflows are currently in GitHub action_required state for this fork PR, so no jobs/logs are available yet. Local validation before opening: scripts/run_tests.sh tests/cron -q → 323 passed; npm run lint:diagrams → 0 errors; npm run build completed successfully with existing unrelated broken-link warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cron Cron scheduler and job management P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants