fix(tool): correct Windows path handling in write_file and add sessio…#21027
Open
leonard9893 wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(tool): correct Windows path handling in write_file and add sessio…#21027leonard9893 wants to merge 1 commit intoNousResearch:mainfrom
leonard9893 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
…n state repair for interrupt resilience Bug 1 (Windows path handling): - Add _normalize_windows_path() to detect and convert Unix-style paths (e.g. /Users/zimu/...) to proper Windows paths (C:\Users\...) on Windows - Add _detect_hardcoded_username() to warn when model generates paths with hardcoded usernames (training-data contamination) - Write_file_tool now performs parent directory existence check on Windows - Add OS-aware path validation with warnings for wrong platform paths Bug 2 (Session interrupt tool call loss): - Add _validate_and_repair_session_state() to strip orphan tool_calls and trailing tool result messages after session interrupt/resume - Fix corrupted message sequences that contain incomplete tool-call patterns (assistant with tool_calls but no matching tool results) - Remove terminal tool/function messages so the API doesn't reject Bug 3 (Tool execution hallucination): - Add _detect_tool_call_hallucination() that catches model responses claiming tool execution (e.g. "I've written the file") with zero actual tool_calls — common after session resume - On detection, inject a nudge message retrying with actual tool calls instead of accepting the hallucination as the final answer Closes NousResearch#20927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n state repair for interrupt resilience
Bug 1 (Windows path handling):
Bug 2 (Session interrupt tool call loss):
Bug 3 (Tool execution hallucination):
Closes #20927
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs