Skip to content

fix: keep background process notifications out of model input#20922

Open
acc001k wants to merge 1 commit intoNousResearch:mainfrom
acc001k:upstream-pr/runtime-clean-background-notifications-20260506
Open

fix: keep background process notifications out of model input#20922
acc001k wants to merge 1 commit intoNousResearch:mainfrom
acc001k:upstream-pr/runtime-clean-background-notifications-20260506

Conversation

@acc001k
Copy link
Copy Markdown

@acc001k acc001k commented May 6, 2026

Summary

  • keep CLI background process completion notifications on a display-only path instead of feeding them back as pending user input
  • deliver gateway background process notifications directly to the original chat target instead of re-entering the message handler as internal user input
  • contain shell option side effects from local background commands by running user commands inside a subshell wrapper

Test Plan

  • python -m py_compile cli.py gateway/run.py tools/process_registry.py hermes_cli/kanban_db.py
  • git diff --check origin/main...HEAD
  • python -m pytest -o addopts= -n 4 --ignore=tests/integration --ignore=tests/e2e -m 'not integration' tests/cli/test_cli_background_process_notifications.py tests/gateway/test_background_process_notifications.py tests/tools/test_notify_on_complete.py

Targeted pytest result: 57 passed.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery tool/terminal Terminal execution and process management P2 Medium — degraded but workaround exists labels May 6, 2026
@acc001k acc001k force-pushed the upstream-pr/runtime-clean-background-notifications-20260506 branch 8 times, most recently from d46270b to 42239c6 Compare May 8, 2026 20:35
@acc001k acc001k force-pushed the upstream-pr/runtime-clean-background-notifications-20260506 branch from 59e15c0 to 0129f1d Compare May 9, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists tool/terminal Terminal execution and process management type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants