fix: validate assembled skill (evolved_full) not raw body (evolved_body)#50
Open
zuquanzhi wants to merge 1 commit intoNousResearch:mainfrom
Open
fix: validate assembled skill (evolved_full) not raw body (evolved_body)#50zuquanzhi wants to merge 1 commit intoNousResearch:mainfrom
zuquanzhi wants to merge 1 commit intoNousResearch:mainfrom
Conversation
The validator checks for YAML frontmatter (---, name:, description:) but was passed evolved_body (plain markdown without frontmatter). Changed to evolved_full which is reassembled with skill frontmatter. Fixes false negative on skill_structure constraint check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
evolve_skill.pyline 189 validatesevolved_body(raw DSPy output without YAML frontmatter) against theskill_structureconstraint. The constraint checks for---,name:, anddescription:— which only exist in the reassembled skill with frontmatter.This causes a false negative: the evolution completes successfully and produces valid output, but the validator rejects it with:
Fix
One-line change: pass
evolved_full(reassembled with frontmatter on line 185) instead ofevolved_body.Verification
evolved_fullalready contains valid YAML frontmatter (line 185:reassemble_skill(skill["frontmatter"], evolved_body))