fix: extract evolved skill body from optimized predictor#49
Open
steezkelly wants to merge 2 commits intoNousResearch:mainfrom
Open
fix: extract evolved skill body from optimized predictor#49steezkelly wants to merge 2 commits intoNousResearch:mainfrom
steezkelly wants to merge 2 commits intoNousResearch:mainfrom
Conversation
Author
|
Local verification refresh from a clean temporary checkout of this PR:
GitHub currently reports no visible Actions runs/checks for this branch, so local verification is the available signal for now. |
Author
|
Update: added a minimal GitHub Actions pytest workflow to this branch so the repo has an in-repo CI definition going forward. Local verification after the workflow commit ( cd /tmp/self-evolution-pr49-ci
/home/steve/hermes0/hermes-agent-self-evolution/venv/bin/python -m py_compile $(find evolution -name '*.py' -print)
/home/steve/hermes0/hermes-agent-self-evolution/venv/bin/python -m pytest tests/skills/test_skill_module.py tests/skills/test_evolve_skill_extraction.py -q
# 12 passed, 11 warnings
/home/steve/hermes0/hermes-agent-self-evolution/venv/bin/python -m pytest -q
# 144 passed, 11 warningsNote: GitHub currently shows no regular Actions runs for this repo/branch; upstream only has the Copilot code review workflow visible. The new workflow is included in the PR so future pushes/PRs can run |
This was referenced May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope control
This is the focused split from the broad PR #39 for the ghost-improvement bug only.
It intentionally does not include:
output/artifactsTest plan
/home/steve/hermes0/hermes-agent-self-evolution/venv/bin/python -m pytest tests/skills/test_skill_module.py tests/skills/test_evolve_skill_extraction.py -q/home/steve/hermes0/hermes-agent-self-evolution/venv/bin/python -m pytest -qResult: 144 passed, 11 warnings.
Issue #38 relationship
This PR addresses the ghost-improvement extraction portion of #38: the optimized predictor must expose the actual evolved skill body, rather than reporting improved scores while saving the baseline body.
It intentionally leaves the remaining #38 follow-ups open for focused PRs: