-
Notifications
You must be signed in to change notification settings - Fork 20
(mama) utils to detect lockfiles #576 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codingdestro
wants to merge
5
commits into
NodeSecure:master
Choose a base branch
from
codingdestro:dev/mama-utils
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@nodesecure/mama": minor | ||
| --- | ||
|
|
||
| Added lockfile scanning utils |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export * from "./integrity-hash.ts"; | ||
| export * from "./inspectModuleType.ts"; | ||
| export * from "./parseNpmSpec.ts"; | ||
| export * from "./scan-lockfiles.ts"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Import Node.js Dependencies | ||
| import fs from "node:fs"; | ||
| import path from "node:path"; | ||
|
|
||
| export const LOCK_FILES = { | ||
| npm: "package-lock.json", | ||
| bun: "bun.lockb", | ||
| yarn: "yarn.lock", | ||
| pnpm: "pnpm-lock.yaml" | ||
| }; | ||
|
|
||
| export function scanLockFiles(dirPath: string): null | object { | ||
| const result: { [k: string]: string; } = {}; | ||
| for (const [k, v] of Object.entries(LOCK_FILES)) { | ||
| const filePath = path.join(dirPath, v); | ||
| if (fs.existsSync(filePath)) { | ||
| result[k] = filePath; | ||
| } | ||
|
Comment on lines
+16
to
+18
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably better to use fs.readdirSync instead of doing 1..N I/O fs (N being the number of elements in LOCK_FILES) |
||
| } | ||
|
|
||
| const isEmpty = Object.keys(result).length === 0; | ||
|
|
||
| return isEmpty ? null : result; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Import Node.js Dependencies | ||
| import { describe, test } from "node:test"; | ||
| import assert from "node:assert"; | ||
| import fs from "node:fs"; | ||
| import os from "node:os"; | ||
| import path from "node:path"; | ||
|
|
||
| // Import Internal Dependencies | ||
| import { scanLockFiles, LOCK_FILES } from "../src/index.ts"; | ||
|
|
||
| describe("scanLockFiles", () => { | ||
| test("should scan lock files", () => { | ||
| const output: typeof LOCK_FILES = {} as typeof LOCK_FILES; | ||
| const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "/")); | ||
|
|
||
| for (const [k, v] of Object.entries(LOCK_FILES)) { | ||
| const filepath = path.join(tmpDir, v); | ||
|
|
||
| fs.writeFileSync(filepath, ""); | ||
| output[k as keyof typeof LOCK_FILES] = filepath; | ||
| } | ||
|
|
||
| assert.deepEqual(scanLockFiles(tmpDir), output); | ||
| }); | ||
|
|
||
| test("should return null no lockfiles", () => { | ||
| const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "/")); | ||
| assert.deepEqual(scanLockFiles(tmpDir), null); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would work with an Array from the start to avoid useless lookup, at the end you can use Object.fromEntries