refactor(tree-walker): re-abstract tree loading#566
Merged
Conversation
🦋 Changeset detectedLatest commit: 0e844a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8ec0384 to
0ff4671
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors tree loading logic by introducing a TreeDependencies class to encapsulate dependency filtering and transformation. The main change abstracts the complexity of filtering Arborist nodes based on dev dependencies and workspace settings away from the walker implementation.
- Introduces
TreeDependenciesclass to handle dependency filtering from Arborist nodes - Updates
LocalDependencyTreeLoaderto returnTreeDependenciesinstead of rawArborist.Node - Adds comprehensive tests for
LocalDependencyTreeLoader
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
workspaces/tree-walker/src/npm/TreeDependencies.ts |
New class that encapsulates logic for filtering and transforming Arborist node edges into a Map of dependencies |
workspaces/tree-walker/src/npm/LocalDependencyTreeLoader.ts |
Updated to return TreeDependencies instead of Arborist.Node, with options now bundled into a single object |
workspaces/tree-walker/src/npm/walker.ts |
Refactored to use TreeDependencies API, simplifying the dependency iteration logic |
workspaces/tree-walker/test/npm/LocalDependencyTreeLoader.spec.ts |
New test file covering both virtual and actual tree loading scenarios |
workspaces/tree-walker/test/fixtures/tree-loader-virtual/package.json |
Test fixture for tree loading tests |
workspaces/tree-walker/test/fixtures/tree-loader-virtual/package-lock.json |
Lock file fixture for virtual tree loading test |
.changeset/yummy-knives-grab.md |
Changeset documenting this as a minor version change |
Files not reviewed (1)
- workspaces/tree-walker/test/fixtures/tree-loader-virtual/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0ff4671 to
0e844a4
Compare
PierreDemailly
approved these changes
Nov 29, 2025
clemgbld
approved these changes
Nov 29, 2025
This was referenced Nov 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.