Skip to content

Conversation

@fraxken
Copy link
Member

@fraxken fraxken commented Aug 12, 2025

No description provided.

@fraxken fraxken requested a review from Copilot August 12, 2025 21:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2025

🦋 Changeset detected

Latest commit: f2a6e6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nodesecure/mama Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the packageJSONIntegrityHash function to always remove ./node_modules/.bin/ prefixes from package scripts when computing integrity hashes, regardless of whether the package comes from a remote registry. Previously, this normalization only occurred for packages from remote registries.

  • Simplified the logic by always applying removeNodeModulesBin to scripts
  • Updated the test to verify the behavior works consistently for both local and remote registry scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
workspaces/mama/src/utils/integrity-hash.ts Removed conditional logic and always apply removeNodeModulesBin to scripts
workspaces/mama/test/packageJSONIntegrityHash.spec.ts Enhanced test to verify behavior for both undefined and { isFromRemoteRegistry: true } options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fraxken fraxken force-pushed the mama-integrity-bin-modules branch from 8b9fba0 to f2a6e6e Compare August 12, 2025 21:17
@fraxken fraxken merged commit 045c378 into master Aug 12, 2025
5 checks passed
@fraxken fraxken deleted the mama-integrity-bin-modules branch August 12, 2025 23:52
@github-actions github-actions bot mentioned this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants