feat: resolveOnNpmRegistry option #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreDemailly
force-pushed
the
resolve-npm-option
branch
from
305226b to
29db378
Compare
fraxken
requested changes
Jun 24, 2023
src/index.ts
Outdated
Comment on lines
104
to
106
| catch { | ||
| failed = true; | ||
| } |
Member
There was a problem hiding this comment.
catch (error) {
throw new Error("Invalid repository, cannot find it on GitHub or NPM registry", {
cause: error
});
}You need to update the target to ES2022 in tsconfig.json
fraxken
reviewed
Jun 24, 2023
src/index.ts
Outdated
| // If the repository is not found, we try to retrieve it from the NPM registry | ||
| // i.e: if given repository is "@nodesecure/cli" | ||
| if (!resolveOnNpmRegistry) { | ||
| throw new Error("Invalid repository, cannot find it on GitHub"); |
fraxken
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.