Skip to content

Conversation

@PierreDemailly
Copy link
Member

As discussed here: NodeSecure/cli#164 (comment)

@fraxken
Copy link
Member

fraxken commented Feb 2, 2023

@PierreDemailly Please rename variable. The convention using k is only applicable for local constant (if you export it from a module it should be in MAJ).

For example:

import * as scorecard from "@nodesecure/ossf-scorecard-sdk";

// BAD
console.log(scorecard.kOpenSSFScorecardRestApi);

// OK
console.log(scorecard.API_URL);

@fraxken fraxken merged commit a01d904 into main Feb 2, 2023
@fraxken fraxken deleted the export-scorecard-api-url branch February 2, 2023 13:38
@fraxken
Copy link
Member

fraxken commented Feb 11, 2023

@all-contributors please add @PierreDemailly for code

@allcontributors
Copy link
Contributor

@fraxken

I've put up a pull request to add @PierreDemailly! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants