Skip to content

Conversation

@0xbigtang
Copy link
Contributor

Pull Request - Frontend | 前端 PR

💡 提示 Tip: 推荐 PR 标题格式 type(scope): description
例如: feat(ui): add dark mode toggle | fix(form): resolve validation bug


📝 Description | 描述

English: Restore the logout control in admin mode so administrators can sign out from the HeaderBar again.
中文: 恢复管理员模式下的登出按钮,确保登录管理员能够在 HeaderBar 中正常退出登录。


🎯 Type of Change | 变更类型

  • 🐛 Bug fix | 修复 Bug
  • ✨ New feature | 新功能
  • 💥 Breaking change | 破坏性变更
  • 🎨 Code style update | 代码样式更新
  • ♻️ Refactoring | 重构
  • ⚡ Performance improvement | 性能优化

🔗 Related Issues | 相关 Issue

  • Closes # | 关闭 #
  • Related to # | 相关 #

📋 Changes Made | 具体变更

English:中文:


📸 Screenshots / Demo | 截图/演示

Before | 变更前:

After | 变更后:


🧪 Testing | 测试

Test Environment | 测试环境

  • OS | 操作系统:
  • Node Version | Node 版本:
  • Browser(s) | 浏览器:

Manual Testing | 手动测试

  • Tested in development mode | 开发模式测试通过
  • Tested production build | 生产构建测试通过
  • [x ] Tested on multiple browsers | 多浏览器测试通过
  • Tested responsive design | 响应式设计测试通过
  • Verified no existing functionality broke | 确认没有破坏现有功能

🌐 Internationalization | 国际化

  • All user-facing text supports i18n | 所有面向用户的文本支持国际化
  • Both English and Chinese versions provided | 提供了中英文版本
  • N/A | 不适用

✅ Checklist | 检查清单

Code Quality | 代码质量

  • Code follows project style | 代码遵循项目风格
  • Self-review completed | 已完成代码自查
  • Comments added for complex logic | 已添加必要注释
  • Code builds successfully | 代码构建成功 (npm run build)
  • Ran npm run lint | 已运行 npm run lint
  • No console errors or warnings | 无控制台错误或警告

Testing | 测试

  • Component tests added/updated | 已添加/更新组件测试
  • Tests pass locally | 测试在本地通过

Documentation | 文档

  • Updated relevant documentation | 已更新相关文档
  • Updated type definitions (TypeScript) | 已更新类型定义
  • Added JSDoc comments where necessary | 已添加 JSDoc 注释

Git

  • Commits follow conventional format | 提交遵循 Conventional Commits 格式
  • Rebased on latest dev branch | 已 rebase 到最新 dev 分支
  • No merge conflicts | 无合并冲突

📚 Additional Notes | 补充说明

English:中文:


By submitting this PR, I confirm | 提交此 PR,我确认:

  • I have read the Contributing Guidelines | 已阅读贡献指南
  • I agree to the Code of Conduct | 同意行为准则
  • My contribution is licensed under AGPL-3.0 | 贡献遵循 AGPL-3.0 许可证

🌟 Thank you for your contribution! | 感谢你的贡献!

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

🤖 Advisory Check Results

These are advisory checks to help improve code quality. They won't block your PR from being merged.

📋 PR Information

Title Format: ✅ Good - Follows Conventional Commits
PR Size: 🟢 Small (4 lines: +2 -2)

🔧 Backend Checks

Go Formatting: ⚠️ Needs formatting

Files needing formatting
api/server.go
decision/engine.go
logger/telegram_sender.go
mcp/client.go
trader/aster_trader.go
trader/auto_trader.go
trader/binance_futures.go
trader/hyperliquid_trader.go

Go Vet: ✅ Good
Tests: ✅ Passed

Fix locally:

go fmt ./...      # Format code
go vet ./...      # Check for issues
go test ./...     # Run tests

⚛️ Frontend Checks

Build & Type Check: ✅ Success

Fix locally:

cd web
npm run build  # Test build (includes type checking)

📖 Resources

Questions? Feel free to ask in the comments! 🙏


These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml.

Copy link
Collaborator

@SkywalkerJi SkywalkerJi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢PR,已经合并。

@SkywalkerJi SkywalkerJi merged commit 28a63f4 into NoFxAiOS:dev Nov 7, 2025
13 of 15 checks passed
ForeverInLaw pushed a commit to ForeverInLaw/nofx that referenced this pull request Nov 8, 2025
xqliu pushed a commit to nofxai/nofx that referenced this pull request Nov 9, 2025
bebest2010 pushed a commit to bebest2010/nofx that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants