fix(margin): correct position sizing formula to prevent insufficient margin errors #435
Conversation
… string
## Problem
When editing trader configuration, if `system_prompt_template` was set to an empty string (""), the UI would incorrectly treat it as falsy and overwrite it with 'default', losing the user's selection.
**Root cause:**
```tsx
if (traderData && !traderData.system_prompt_template) {
// ❌ This triggers for both undefined AND empty string ""
setFormData({ system_prompt_template: 'default' });
}
```
JavaScript falsy values that trigger `!` operator:
- `undefined` ✅ Should trigger default
- `null` ✅ Should trigger default
- `""` ❌ Should NOT trigger (user explicitly chose empty)
- `false`, `0`, `NaN` (less relevant here)
## Solution
Change condition to explicitly check for `undefined`:
```tsx
if (traderData && traderData.system_prompt_template === undefined) {
// ✅ Only triggers for truly missing field
setFormData({ system_prompt_template: 'default' });
}
```
## Impact
- ✅ Empty string selections are preserved
- ✅ Legacy data (undefined) still gets default value
- ✅ User's explicit choices are respected
- ✅ No breaking changes to existing functionality
## Testing
- ✅ Code compiles
- ⚠️ Requires manual UI testing:
- [ ] Edit trader with empty system_prompt_template
- [ ] Verify it doesn't reset to 'default'
- [ ] Create new trader → should default to 'default'
- [ ] Edit old trader (undefined field) → should default to 'default'
## Code Changes
```
web/src/components/TraderConfigModal.tsx:
- Line 99: Changed !traderData.system_prompt_template → === undefined
```
🤖 Advisory Check ResultsThese are advisory checks to help improve code quality. They won't block your PR from being merged. 📋 PR InformationTitle Format: ✅ Good - Follows Conventional Commits 🔧 Backend ChecksGo Formatting: Files needing formattingGo Vet: ✅ Good Fix locally: go fmt ./... # Format code
go vet ./... # Check for issues
go test ./... # Run tests⚛️ Frontend ChecksBuild & Type Check: ✅ Success Fix locally: cd web
npm run build # Test build (includes type checking)📖 ResourcesQuestions? Feel free to ask in the comments! 🙏 These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml. |
🤖 Advisory Check ResultsThese are advisory checks to help improve code quality. They won't block your PR from being merged. 📋 PR InformationTitle Format: ✅ Good - Follows Conventional Commits 🔧 Backend ChecksGo Formatting: Files needing formattingGo Vet: ✅ Good Fix locally: go fmt ./... # Format code
go vet ./... # Check for issues
go test ./... # Run tests⚛️ Frontend ChecksBuild & Type Check: ✅ Success Fix locally: cd web
npm run build # Test build (includes type checking)📖 ResourcesQuestions? Feel free to ask in the comments! 🙏 These checks are advisory and won't block your PR from being merged. This comment is automatically generated from pr-checks-run.yml. |
…erwrite fix(margin): correct position sizing formula to prevent insufficient margin errors
2 participants
Problem
When editing trader configuration, if
system_prompt_templatewas set to an empty string (""), the UI would incorrectly treat it as falsy and overwrite it with 'default', losing the user's selection.Root cause:
JavaScript falsy values that trigger
!operator:undefined✅ Should trigger defaultnull✅ Should trigger default""❌ Should NOT trigger (user explicitly chose empty)false,0,NaN(less relevant here)Solution
Change condition to explicitly check for
undefined:Impact
Testing
Code Changes
📝 Description | 描述
English:
Fixed critical bug where AI was calculating
position_size_usdincorrectly, treating it as margin requirement instead of notional value, causing frequent code=-2019 errors (insufficient margin).中文：
修復關鍵 bug：AI 錯誤計算
position_size_usd，將其視為保證金需求而非名義價值，導致頻繁出現 code=-2019 錯誤（保證金不足）。🎯 Type of Change | 變更類型
🔗 Related Issues | 相關 Issue
📋 Changes Made | 具體變更
English:
Updated AI prompts with correct formula (
prompts/adaptive.txt,nof1.txt,default.txt):position_size_usdis notional value (includes leverage)Available Margin × Leverage = position_size_usdAdded code-level validation (
trader/auto_trader.go):required margin + fees ≤ available balancebefore opening positions中文：
更新 AI 提示詞公式 (
prompts/adaptive.txt,nof1.txt,default.txt):position_size_usd是名義價值（包含杠杆）可用保證金 × 杠杆 = position_size_usd新增代碼級驗證 (
trader/auto_trader.go):🧪 Testing | 測試
Manual Testing | 手動測試
Test Environment | 測試環境
Test Results | 測試結果
✅ Checklist | 檢查清單
Code Quality | 代碼質量
go build)Testing | 測試
Documentation | 文檔
Git
fix:)devbranch | 我已將分支 rebase 到最新的dev分支📋 PR Size Estimate | PR 大小估計
🎯 Review Focus Areas | 審查重點
Please pay special attention to:
請特別注意：
Specific areas:
executeOpenLong/ShortWithRecordBy submitting this PR, I confirm that:
提交此 PR，我確認：